chore: remove batch reply statistics #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romange
commented
Jan 27, 2024
romange
commented
- average batch latency will always be 0, because even in cases we have outliers they will be dominated by small CPU only copies that take dozens of ns.
- Measuring an operation like kBatch, which is solely CPU-based, necessitated the use of a clock. According to the CPU profiler, this contributed to approximately 5% of the CPU usage.
|
I don't understand why instead of unconditionally adding (obviously not zero cost) tracing and then removing it completely, we didn't introduce a proper macro for enabling or disabling all kinds of tracing during builds. What do we do next time we want to get reply batching stats to analyze a specific scenario? 😄(🤨) |
|
Batching measures only the cpu work. It never worked as intended and that's what we are removing. We still keep the part that measures the actual socket latency |
1. average batch latency will always be 0, because even in cases we have outliers they will be dominated by small CPU only copies that take dozens of ns. 2. Measuring an operation like kBatch, which is solely CPU-based, necessitated the use of a clock. According to the CPU profiler, this contributed to approximately 5% of the CPU usage. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
force-pushed
the
RemoveReplyStat
branch
from
2730fae
to
4fab61e
Compare
chakaz
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.