-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): Implement CONFIG HELP command #2510
Conversation
Thank you! We have not reached conclusions that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Please see super small nits, but otherwise looks good :)
src/server/server_family.cc
Outdated
"RESETSTAT", | ||
" Reset statistics reported by the INFO command.", | ||
"HELP", | ||
" Prints this help."}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" Prints this help."}; | |
" Prints this help." | |
}; |
src/server/server_family.cc
Outdated
rb->SendSimpleStrArr(help_arr); | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rb->SendSimpleStrArr(help_arr); | |
return; | |
return rb->SendSimpleStrArr(help_arr); |
@chakaz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again!
Related Issue: #857
The
CONFIG HELP
command is implemented in this PR.The implementation of the
CONFIG HELP
command in Redis 7.2 was used as a reference.The notation of the
CONFIG HELP
command in Redis 7.2 is as follows.The
CONFIG REWRITE
command is not yet implemented in the current DragonflyDB.The newly implemented
CONFIG HELP
command excludes theCONFIG REWRITE
command.