fix: do not crash with inconsistent watch queue #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output more info about the state of things. Skip the non existent key and continue the execution. Fixes #2514 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
|
There is no infomation about the bug scenario itself and whether this PR fixes (by changing awakened_keys backing) it or "fixes" it just by printing internal error |
updated the description. Yes, it does not fix the root cause. |
romange
added a commit
that referenced
this pull request
Feb 3, 2024
Output more info about the state of things. Skip the non existent key and continue the execution. Fixes #2514 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output more info about the state of things.
Skip the non existent key and continue the execution. Fixes #2514
This PR does not fix the root reason but provides the workaround that hopefully avoid crash, and also provides an important context that would allow us to progress in understanding of the issue.