Fix: awakened_keys inconcistency #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Pr1
branch
4 times, most recently
from
af1dbb9
to
2c7ada8
Compare
1. Remove the duplicated FinalizeWatched function 2. Identify the case where we delete the watched queue while we may still have awakedened_keys pointing to it. 3. Add a test reproducing the issue of having in awakened_keys an untangled key. Properly fixes #2514 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
|
This reproduces the failed path: |
dranikpg
approved these changes
Feb 1, 2024
| @@ -214,6 +178,8 @@ void BlockingController::NotifyPending() { | |||
| DVLOG(1) << "Processing awakened key " << sv_key; | |||
| auto w_it = wt.queue_map.find(sv_key); | |||
| if (w_it == wt.queue_map.end()) { | |||
| // This should not happen because we remove keys from awakened_keys every type we remove | |||
| // the entry from queue_map. TODO: to make it a CHECK after Dec 2024 | |||
There was a problem hiding this comment.
I foresee us totally missing this line in december 🤣
There was a problem hiding this comment.
we can grep TODOs from time to time and Dec is purely directional :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly fixes #2514