chore: remove redis sorted set implementation #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
requested review from
BorysTheDev and
adiholden
and removed request for
adiholden
dranikpg
reviewed
Feb 2, 2024
romange
force-pushed
the
ReduceRedis
branch
2 times, most recently
from
c837f2c
to
4a61362
Compare
dranikpg
previously approved these changes
Feb 2, 2024
romange
force-pushed
the
ReduceRedis
branch
10 times, most recently
from
6bf0c91
to
b918cac
Compare
BorysTheDev
previously approved these changes
Feb 4, 2024
romange
force-pushed
the
ReduceRedis
branch
8 times, most recently
from
81bd76c
to
9b8ff6d
Compare
romange
force-pushed
the
ReduceRedis
branch
3 times, most recently
from
a82a9db
to
237e601
Compare
Also remove unused code. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
BorysTheDev
reviewed
Feb 5, 2024
| @@ -26,6 +35,14 @@ option(DF_USE_SSL "Provide support for SSL connections" ON) | |||
|
|
|||
| find_package(OpenSSL) | |||
|
|
|||
| if (SUPPORT_ASAN) | |||
| # set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fsanitize=address") | |||
There was a problem hiding this comment.
why it's commented out under macro?
There was a problem hiding this comment.
because it does not work yet. I will enable it in the subsequent PRs.
BorysTheDev
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove unused code.
Add asan and ubsan checks to the debug build but the settings are still disabled for now.