Update helio #2538
Merged
Update helio #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
UpdateHelio
branch
12 times, most recently
from
71bf732
to
5bd2e70
Compare
romange
force-pushed
the
UpdateHelio
branch
3 times, most recently
from
715971f
to
46fca5e
Compare
Add support for asan/ubsan checkers in our dev environment. Remove more clang warnings. Once we fix all the problems we will enable them in our CI as well. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
commented
Feb 6, 2024
| @@ -1,11 +1,9 @@ | |||
| option(DF_ENABLE_MEMORY_TRACKING "Adds memory tracking debugging via MEMORY TRACK command" ON) | |||
There was a problem hiding this comment.
just reshuffling code here
kostasrim
reviewed
Feb 6, 2024
| @@ -3268,7 +3268,7 @@ void ZSetFamily::Register(CommandRegistry* registry) { | |||
| << CI{"ZREM", CO::FAST | CO::WRITE, -3, 1, 1, acl::kZRem}.HFUNC(ZRem) | |||
| << CI{"ZRANGE", CO::READONLY, -4, 1, 1, acl::kZRange}.HFUNC(ZRange) | |||
| << CI{"ZRANDMEMBER", CO::READONLY, -2, 1, 1, acl::kZRandMember}.HFUNC(ZRandMember) | |||
| << CI{"ZRANK", CO::READONLY | CO::FAST, 3, 1, 1, acl::kZRange}.HFUNC(ZRank) | |||
| << CI{"ZRANK", CO::READONLY | CO::FAST, 3, 1, 1, acl::kZRank}.HFUNC(ZRank) | |||
| @@ -94,9 +106,15 @@ jobs: | |||
| - name: Build | |||
| run: | | |||
| cd ${GITHUB_WORKSPACE}/build | |||
| ninja search_family_test | |||
There was a problem hiding this comment.
it's an arbitrary target that we would build anyway provides a consistent target being built. helps if there is a failure like disk space which gets lost when we build multiple targets in parallel.
| run: | | ||
| uname -a | ||
| cmake --version | ||
| mkdir -p ${GITHUB_WORKSPACE}/build | ||
|
|
||
| echo "===================Before freeing up space ============================================" |
There was a problem hiding this comment.
because -fsanitize eats up all the space on the runner and we fail building the repo
BorysTheDev
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for asan/ubsan checkers in our dev environment.
Once we fix all the problems we will enable them in our CI as well.
Fix most of the clang warnings