fix(server): Do not yield in journal if not allowed #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix looks good. I would add a pytest that does replication with one command executing (f.e setex) that uses journal rewrite. |
adiholden
reviewed
Feb 5, 2024
tests/dragonfly/replication_test.py
Outdated
| await wait_available_async(c_replica) | ||
| await stream_task | ||
|
|
||
| # TODO: compare master and replica once we have the utility to do so. |
There was a problem hiding this comment.
maybe at least for now check that all keys exist in master also exist in replica? with keys command
adiholden
reviewed
Feb 5, 2024
adiholden
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the second crash reported in #2500.