fix: wrongly printing timedout emoji on test failures #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kostasrim
commented
Feb 5, 2024
kostasrim
commented
- fix wrongly printing timedout emoji on non timedout test failures
- add pytest-timeout as dependency in tests/dragonfly/requirements
kostasrim
commented
Feb 5, 2024
| @@ -73,11 +87,11 @@ runs: | |||
| TIMEDOUT_STEP_1: ${{ steps.first.outputs.TIMEDOUT }} | |||
| TIMEDOUT_STEP_2: ${{ steps.second.outputs.TIMEDOUT }} | |||
| run: | | |||
| if [[ "${{ env.TIMEDOUT_STEP_1 }}" -eq 1 ]] || [[ "${{ env.TIMEDOUT_STEP_2 }}" -eq 1 ]]; then | |||
| echo "🪵🪵🪵🪵🪵🪵 Latest log before timeout 🪵🪵🪵🪵🪵🪵\n\n" | |||
There was a problem hiding this comment.
These will be removed on a separate PR.
- Will rename all the logs generated to correspond to the id of the instance we assign in instance.py
- Will only upload the logs of failed tests
|
test with timeout injection: https://github.com/dragonflydb/dragonfly/actions/runs/7788079268/job/21236719869#step:6:528 |
adiholden
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.