Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): increase interpreter test load, lower notice limit, include 2553 #2554

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

dranikpg
Copy link
Contributor

@dranikpg dranikpg commented Feb 6, 2024

  1. Increase load and lower limit for flaky test (release build was too fast)
  2. Include 2553 by Romans request

adiholden
adiholden previously approved these changes Feb 6, 2024
@adiholden
Copy link
Collaborator

@romange @dranikpg maybe we can mark this test to skip now so we can create the version and vlad can continue working on stabilising it meanwhile

romange
romange previously approved these changes Feb 6, 2024
@dranikpg dranikpg dismissed stale reviews from romange and adiholden via a3f3811 February 6, 2024 14:25
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
@romange romange merged commit ed59a43 into dragonflydb:main Feb 6, 2024
7 checks passed
romange pushed a commit that referenced this pull request Feb 6, 2024
…de 2553 (#2554)

* fix: increase load + lower notice limit

* chore: include 2553

* fix: lower metric EVEN more

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>

---------

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange pushed a commit that referenced this pull request Feb 6, 2024
…de 2553 (#2554)

* chore: include 2553
* disable test_one_interpreter

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>

---------

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@dranikpg dranikpg deleted the fix-ipt-test branch February 6, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants