Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tiering tests): introduce wait until tiering entries num EQ/GT #2559

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

adiholden
Copy link
Collaborator

fixes #2541
Tiering unit tests might fail in github as we wait for fixed time 20 mili for writing to disc.
This PR introduces wait until condition function util for unit tests
Tiering unit tests use this function to wait untill the tiered entries counter is updated or fail on timeout

Signed-off-by: adi_holden <adi@dragonflydb.io>
@adiholden adiholden requested a review from chakaz February 7, 2024 13:14
chakaz
chakaz previously approved these changes Feb 7, 2024
@adiholden adiholden enabled auto-merge (squash) February 7, 2024 14:31
@adiholden adiholden changed the title fix(tiering tests): introduce wait until tieting entries num EQ/GT fix(tiering tests): introduce wait until tiering entries num EQ/GT Feb 7, 2024
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
@adiholden adiholden merged commit 7b61b4a into main Feb 14, 2024
10 checks passed
@adiholden adiholden deleted the fix_2541 branch February 14, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test TieredStorageTest.AddBigValues fails
2 participants