fix: asan errors on unit tests #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Feb 8, 2024
| memcpy(next, slices[0].data(), slices[0].size()); | ||
| next += slices[0].size(); | ||
| memcpy(next, slices[1].data(), slices[1].size()); | ||
| detail::ascii_unpack_simd(reinterpret_cast<uint8_t*>(dest + space_left), decoded_len, dest); | ||
| detail::ascii_unpack_simd(reinterpret_cast<uint8_t*>(tmp.data()), decoded_len, dest); |
There was a problem hiding this comment.
I need to check in other places as well. The problem is that we overshoot the buffer. We read starting from dest + space_left and we simd load 16 bytes. On the second iteration we increment dest by 14, which causes the starting address to be at pos 18 (because space_left == 4) and we read another 16 bytes overshooting the 32 available bytes
dranikpg
reviewed
Feb 8, 2024
| VarintBuffer ranged_source{0}; | ||
| memcpy(&ranged_source, source.data(), source.size()); | ||
| absl::Span<const uint8_t> source2 = absl::MakeSpan(ranged_source); | ||
| read = base::flit::ParseT(source2.data(), &out); |
There was a problem hiding this comment.
Good catch, it's actually written in the flit comments. You don't need a span to get a pointer, you can pass directly
dranikpg
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on romange/helio#213 (once it's merged I will pull the latest helio here)