chore: provide plumbing for jsonpath error propagation #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
JsonPathErrors
branch
from
fce8da2
to
456c1c6
Compare
Also update re/flex library to the latest version. Finally, introduce very basic parser test. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
force-pushed
the
JsonPathErrors
branch
from
456c1c6
to
fc9c132
Compare
romange
force-pushed
the
JsonPathErrors
branch
2 times, most recently
from
4ce4c76
to
e4b30a7
Compare
Parse jsonpath and partially fill it with path segments. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
force-pushed
the
JsonPathErrors
branch
from
e4b30a7
to
ed29d87
Compare
BorysTheDev
previously approved these changes
Feb 12, 2024
src/core/json/driver.h
Outdated
| path_.AddSegment(PathSegment(SegmentType::IDENTIFIER, identifier)); | ||
| } | ||
|
|
||
| Path Release() { |
There was a problem hiding this comment.
I would prefer to rename this method to TakePath()
| int index_; | ||
| }; | ||
|
|
||
| class Path { |
There was a problem hiding this comment.
I don't understand why you need this class. It duplicates std::vector interface
There was a problem hiding this comment.
it's gonna grow in the future. the code is not finished yet
BorysTheDev
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update re/flex library to the latest version. Finally, introduce very basic parser test.