chore: add jsonpath evaluate #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Pr1
branch
2 times, most recently
from
210283f
to
e81ef06
Compare
BorysTheDev
reviewed
Feb 14, 2024
BorysTheDev
reviewed
Feb 14, 2024
BorysTheDev
reviewed
Feb 14, 2024
BorysTheDev
previously approved these changes
Feb 14, 2024
BorysTheDev
reviewed
Feb 14, 2024
src/core/json/path.cc
Outdated
Comment on lines
95
to
98
| if (it == obj_->array_range().end()) { | ||
| return nullptr; | ||
| } | ||
| return &*it; |
There was a problem hiding this comment.
nit: return it == obj_->array_range().end() ? nullptr : &*it;
BorysTheDev
previously approved these changes
Feb 14, 2024
dranikpg
previously approved these changes
Feb 14, 2024
src/core/json/path.cc
Outdated
Comment on lines
54
to
60
|
|
||
| using AdvanceResult = nonstd::expected<const JsonType*, MatchStatus>; | ||
|
|
||
| class Item { |
There was a problem hiding this comment.
A few comments what those classes contain wouldn't hurt 🙂 Because otherwise you have to figure it out based on their usage
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
dranikpg
previously approved these changes
Feb 14, 2024
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
BorysTheDev
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.