chore(transaction): Untie scheduling from multi status #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
tx-sched-flag
branch
from
423924b
to
508830e
Compare
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
tx-sched-flag
branch
from
595ab7a
to
86800eb
Compare
romange
reviewed
Feb 18, 2024
romange
reviewed
Feb 18, 2024
|
Can you please expand in the PR description what is the potential ability you unlock with this PR? |
|
Can you please expand in the PR description what is the potential ability you unlock with this PR?
Goal: Being able to use ScheduleSingleHop()/Schedule() as a starter for multi transactions, and thus later allow single hop multi transactions |
dranikpg
force-pushed
the
tx-sched-flag
branch
from
29b9d55
to
3138286
Compare
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
tx-sched-flag
branch
from
3138286
to
b957cd6
Compare
romange
approved these changes
Feb 18, 2024
lsvmello
pushed a commit
to lsvmello/dragonfly
that referenced
this pull request
Feb 19, 2024
) * chore(transaction): Untie scheduling from multi status Idea: We decide whether we have to schedule not based on our multi status (atomic multi), but solely based on the fact if COORD_SCHED is set Goal: Being able to use ScheduleSingleHop()/Schedule() for multi transactions, and thus later allow single hop multi transactions --------- Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves part out of #2376
Idea: We decide whether we have to schedule not based on our multi status (atomic multi), but solely based on the fact if COORD_SCHED is set
Goal: Being able to use ScheduleSingleHop()/Schedule() for multi transactions, and thus later allow single hop multi transactions