chore: cleanup of redis implementation of sets/hashmaps #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
CleanRedisDict
branch
2 times, most recently
from
fe646ce
to
f6c7522
Compare
kostasrim
previously approved these changes
Feb 17, 2024
| @@ -1627,7 +1493,7 @@ bool SetFamily::ConvertToStrSet(const intset* is, size_t expected_len, robj* des | |||
| char buf[32]; | |||
| int ii = 0; | |||
|
|
|||
| if (GetFlag(FLAGS_use_set2)) { | |||
| if (true) { | |||
There was a problem hiding this comment.
Otherwise diffs become annoying due to indentation shifts.
|
|
||
| if (IsDenseEncoding(*set)) { | ||
| if (true) { |
| LOG(ERROR) << "OOM in dictTryExpand " << len; | ||
| ec_ = RdbError(errc::out_of_memory); | ||
| return; | ||
| } | ||
|
|
||
| if (use_set2) { | ||
| if (true) { |
There was a problem hiding this comment.
and in other places as well :)
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
force-pushed
the
CleanRedisDict
branch
from
f6c7522
to
e48ea94
Compare
kostasrim
approved these changes
Feb 17, 2024
lsvmello
pushed a commit
to lsvmello/dragonfly
that referenced
this pull request
Feb 19, 2024
…2605) Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.