Add mutate method to jsonpath #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
previously approved these changes
Feb 18, 2024
src/core/json/path.cc
Outdated
Comment on lines
352
to
353
| bool erase = Mutate(cb, it->key(), &it->value()); | ||
| if (erase) { |
There was a problem hiding this comment.
nit:
if (Mutate(cb, it->key(), &it->value())) {
src/core/json/path.cc
Outdated
Comment on lines
386
to
390
| if (res) { | ||
| it = node->erase(it); | ||
| } else { | ||
| ++it; | ||
| } |
There was a problem hiding this comment.
it = res ? node->erase(it) : it + 1;
Comment on lines
+591
to
+617
| auto cb = [&vec](optional<string_view>, JsonType* val) { | ||
| if (val->is_bool()) { | ||
| bool next_val = val->as_bool() ^ true; | ||
| *val = next_val; | ||
| vec.emplace_back(next_val); | ||
| } else { | ||
| vec.emplace_back(nullopt); | ||
| } | ||
| return false; | ||
| }; | ||
| json::MutatePath(expr, std::move(cb), pv.GetJson()); | ||
| it_res->post_updater.Run(); | ||
| op_args.shard->search_indices()->AddDoc(key, op_args.db_cntx, pv); | ||
| } else { | ||
| auto cb = [&vec](const auto&, JsonType& val) { | ||
| if (val.is_bool()) { | ||
| bool current_val = val.as_bool() ^ true; | ||
| val = current_val; | ||
| vec.emplace_back(current_val); | ||
| } else { | ||
| vec.emplace_back(nullopt); | ||
| } | ||
| }; |
There was a problem hiding this comment.
cb are the same but pointer type, I think you can implement one callback via another or do a pointer dereference with constexpr if
There was a problem hiding this comment.
it's not worth it since it's a transitional code and once we are confident it's robust we will delete the old one
There was a problem hiding this comment.
any case I have approved it
BorysTheDev
previously approved these changes
Feb 18, 2024
Plug it in into OpToggle op. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
BorysTheDev
approved these changes
Feb 18, 2024
lsvmello
pushed a commit
to lsvmello/dragonfly
that referenced
this pull request
Feb 19, 2024
* Add mutate method to jsonpath Plug it in into OpToggle op. --------- Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plug it in into OpToggle op.