fix: fix cluster test #2612
Merged
fix: fix cluster test #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
reviewed
Feb 18, 2024
tests/dragonfly/cluster_test.py
Outdated
| @@ -1104,12 +1116,12 @@ async def list_counter(key, client: aioredis.RedisCluster): | |||
| for counter in counters: | |||
| counter.cancel() | |||
|
|
|||
| # Push new config | |||
| await push_config(json.dumps(await generate_config()), [node.admin_client for node in nodes]) | |||
|
|
|||
| # Generate capture, capture ignores counter keys | |||
| capture = await seeder.capture() | |||
There was a problem hiding this comment.
Acually I think we should call capture before we issue SLOT-MIGRATION-FINALIZE
There was a problem hiding this comment.
We can capture before and after, consistency shouldn't break for outside observers. We could even capture 3 times and check it's the same every time
chakaz
approved these changes
Feb 18, 2024
|
I was doing some screenshots for a testing presentation and wanted to show this test as an example. But then I noticed it was wrong 😂 |
adiholden
approved these changes
Feb 18, 2024
lsvmello
pushed a commit
to lsvmello/dragonfly
that referenced
this pull request
Feb 19, 2024
* fix: fix cluster test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test didn't check anything because we pushed the config before actually generating the capture. Note that in my original #2496 this is not the case 🤨