test: Run slow tests in regression runs (again^2) #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Feb 20, 2024
| filter: ${{ matrix.build-type == 'Release' && '' || 'not opt_only' }} | ||
| # Do not filter anything in Release, but do not run opt_only in Debug. Unfortunately an | ||
| # empty string creates a 'false' expression, so we use a non existing mark | ||
| filter: ${{ matrix.build-type == 'Release' && 'not NON_EXISTING_MARK' || 'not opt_only' }} |
There was a problem hiding this comment.
does 'not NON_EXISTING_MARK' or not opt_only still refer to build-type selector?
There was a problem hiding this comment.
no, it's the value of filter. I.e. based on build-type we decide whether the value is not NON_EXISTING_MARK or not opt_only
Feel free to propose a better comment :)
There was a problem hiding this comment.
I suggest to add a line before that this expression serves as a ternary operator, i.e. if the condition holds it returns 'not NON_EXISTING_MARK' otherwise not opt_only
|
I verified that indeed release runs |
adiholden
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.