chore: fix build for MacOs #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
MacOs
branch
2 times, most recently
from
0094772
to
7e4267c
Compare
Also update actions versions to Node 20. This change allows dragonfly to be built on MacOs. However, we still have multiple failing tests on MacOS. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
adiholden
reviewed
Feb 22, 2024
| @@ -132,7 +132,7 @@ jobs: | |||
| # build is broken based on platforms as load: true is not supported with multi-platform builds | |||
| - if: ${{ hashFiles(format('{0}-{1}', matrix.dockerfile, inputs.build_type)) }} | |||
| name: Build release image for amd64 | |||
| uses: docker/build-push-action@v3 | |||
There was a problem hiding this comment.
this jumped from v3 to v5. is this intended?
There was a problem hiding this comment.
yes, see an example here:
https://github.com/docker/build-push-action
adiholden
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update actions versions to Node 20.
This change allows dragonfly to be built on MacOs. However, we still have multiple failing tests.