fix(streamer): Do not yield from the Traverse callback. #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yielding inside the callback can move entries within the bucket, which is unsupported.
adiholden
reviewed
Feb 21, 2024
src/server/journal/streamer.cc
Outdated
| cursor = | ||
| pt->Traverse(cursor, [this](PrimeTable::bucket_iterator it) { WriteBucket(it, true); }); | ||
| cursor = pt->Traverse(cursor, absl::bind_front(&RestoreStreamer::WriteBucket, this)); | ||
| NotifyWritten(true); |
There was a problem hiding this comment.
I dont think its good to call NotifyWritten if nothing was written to buff
adiholden
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yielding inside the callback can move entries within the bucket, which is unsupported.