refactor: create one type for slots set #2459 #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
force-pushed
the
one_type_for_slot_range
branch
from
bde7c7e
to
df4223b
Compare
dranikpg
reviewed
Feb 23, 2024
Comment on lines
+645
to
+646
| options.slot_range = SlotRange{.start = static_cast<SlotId>(start.value()), | ||
| .end = static_cast<SlotId>(end.value())}; |
There was a problem hiding this comment.
nit (not to this PR): it's parse_slot that should have been fixed instead of the static_cast 😄
Comment on lines
+448
to
+450
| for (SlotId slot = 0; slot <= SlotSet::kMaxSlot; ++slot) { | ||
| if (slots.Contains(slot)) | ||
| args.push_back(absl::StrCat(slot)); |
There was a problem hiding this comment.
nit(also not this PR): Wow, this should use slot ranges instead 😵
There was a problem hiding this comment.
I also think so, but It will change the interface of the command, so I decided not doing it now
|
|
||
| class SlotSet { | ||
| public: | ||
| static constexpr SlotId kMaxSlot = 0x3FFF; |
There was a problem hiding this comment.
nit: maybe it's better to use the number that redis uses in decimal format? 16k something... at least it's recognizable visually
There was a problem hiding this comment.
I prefer hex format)
dranikpg
approved these changes
Feb 23, 2024
|
Yes, I can not reduce number of includes and code is really light so I've decided to make it header only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.