chore: JSON.GET now works with our own jsonpath #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
commented
Feb 24, 2024
| @@ -30,6 +30,12 @@ class TestDriver : public Driver { | |||
| } | |||
| }; | |||
|
|
|||
| inline JsonType ValidJson(string_view str) { | |||
There was a problem hiding this comment.
a convenience wrapper
romange
commented
Feb 24, 2024
| @@ -123,6 +129,19 @@ TEST_F(JsonPathTest, Parser) { | |||
| EXPECT_EQ(0, Parse("$.plays[*].game")); | |||
| } | |||
|
|
|||
| TEST_F(JsonPathTest, Root) { | |||
There was a problem hiding this comment.
the only change is this test. Now for empty Path we return the whole object to satisfy $ query.
romange
commented
Feb 24, 2024
| @@ -65,6 +65,17 @@ inline void Evaluate(const json::Path& expr, const JsonType& obj, ExprCallback c | |||
| }); | |||
| } | |||
|
|
|||
| inline JsonType Evaluate(const JsonExpression& expr, const JsonType& obj) { | |||
There was a problem hiding this comment.
a special variant of Evaluate that does not accept a callback and instead returns all the hits as a json array.
romange
commented
Feb 24, 2024
| return expr.evaluate(obj); | ||
| } | ||
|
|
||
| inline JsonType Evaluate(const json::Path& expr, const JsonType& obj) { |
There was a problem hiding this comment.
same variant for json::Path
BorysTheDev
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.