chore: switch to self-built flatbuffers #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should solve the linker errors on MacOs build. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
chakaz
previously approved these changes
Feb 25, 2024
src/core/flatbuffers_test.cc
Outdated
Comment on lines
6
to
10
|
|
||
| #ifndef __USE_GNU // needed to flatbuffers to compile with musl libc. | ||
| #define FLATBUFFERS_LOCALE_INDEPENDENT 0 | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Nit: consider having our own include file to declare this and then include flatbuffers.
chakaz
approved these changes
Feb 26, 2024
kostasrim
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves linker errors on MacOs build.