refactor(cluster): #2652 initiate migration process from CONFIG cmd #2667
Conversation
| @@ -757,12 +770,20 @@ ClusterSlotMigration* ClusterFamily::AddMigration(std::string host_ip, uint16_t | |||
| .get(); | |||
| } | |||
|
|
|||
| void ClusterFamily::RemoveFinishedIncomingMigrations() { | |||
| void ClusterFamily::RemoveFinishedMigrations() { | |||
There was a problem hiding this comment.
but now we should remove a migration from the map only if it is not in the config anymore, right?
There was a problem hiding this comment.
yes I will add this functionality later when remove finalization step
| struct ClusterShard { | ||
| SlotRanges slot_ranges; | ||
| Node master; | ||
| std::vector<Node> replicas; | ||
| std::vector<MigrationInfo> migrations; |
There was a problem hiding this comment.
I think this can be an optional field
There was a problem hiding this comment.
I don't see any point to make it optional if it can be empty
There was a problem hiding this comment.
all the places that you write .migrations = {} can be removed than?
this is just optional data and I think setting .migrations = {} is redundant
There was a problem hiding this comment.
It's a compilation warning, because not members are initialized
There was a problem hiding this comment.
and if we change it to optional?
There was a problem hiding this comment.
compiler thinks that we forget about this field when we use this method of initialization
BorysTheDev
force-pushed
the
start_migration_from_config
branch
from
bb5ce0a
to
ec841d7
Compare
No description provided.