feat(cluster_mgr): Add support for remote Dragonfly servers #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
reviewed
Feb 29, 2024
| target = find_node(config, args.target_port) | ||
| target_node = Node(target["master"]["port"]) | ||
| target = find_node(config, args.target_host, args.target_port) | ||
| target_node = Node(target["master"]["ip"], target["master"]["port"]) |
There was a problem hiding this comment.
Maybe insert update_id in Node construction?
There was a problem hiding this comment.
That's unfortunately not possible because in create_locally we first create the node, and then start it. I could refactor some code I guess but I don't think it's worth it.
But I did move it to be a method instead of a free standing function :)
adiholden
reviewed
Feb 29, 2024
| `--target_host` and `--target_port` | ||
|
|
||
| To set up a new cluster - start the servers and then use | ||
| ./cluster_mgr.py --action=config_single_remote ... |
There was a problem hiding this comment.
I want to discuss the api here to build the remote cluster but this is working now and its ok for the demo so LGTM
There was a problem hiding this comment.
Sure.. let's discuss when you're free :)
But can I haz approval?
adiholden
approved these changes
Feb 29, 2024
romange
pushed a commit
that referenced
this pull request
Mar 1, 2024
* WIP: `cluster_mgr.py` to work with remote targets * Documentation * No admin port * Support different hostname move/migrate * Fix migrate bug * Fix typo in --help * fix test * self.update_id()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for remote Dragonfly server cluster management via
cluster_mgr.py.Also, I updated and extended
--helpwith examples and explanation on how to set up a cluster.As part of this PR I also enable
DFLYCLUSTERcommands via the regular (non-admin) port.