-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(tiering): add prints to find crash flow #2673
Conversation
@theyueli lets try to run this branch, before you run memtier the second time we will set the vmodule flag to see the flow of the crash |
sounds good |
src/server/tiered_storage.cc
Outdated
@@ -480,6 +481,7 @@ bool TieredStorage::PrepareForOffload(DbIndex db_index, PrimeIterator it) { | |||
} | |||
|
|||
void TieredStorage::CancelOffload(DbIndex db_index, PrimeIterator it) { | |||
VLOG(2) << "PrepareForOffload:" << it->first.ToString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: PrepareForCancelOffLoad
src/server/tiered_storage_test.cc
Outdated
@@ -318,4 +319,23 @@ TEST_F(TieredStorageTest, GetValueValidation) { | |||
EXPECT_EQ(m.db_stats[0].tiered_entries, 0); | |||
} | |||
|
|||
TEST_F(TieredStorageTest, CrashBug) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for providing such a template.
@adiholden @theyueli is something pending or shall we close this ? |
@kostasrim I will edit the unit tests for merge later. keep this open |
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
2ca1013
to
9db7299
Compare
No description provided.