feat(dbslice): Add self-laundering iterator in `DbSlice` #2815

chakaz · 2024-04-01T20:14:48Z

A self-laundering iterator will enable us to, eventually, yield from fibers while holding an iterator. For example:

auto it1 = db_slice.Find(...);
Yield();  // Until now - this could have invalidated `it1`
auto it2 = db_slice.Find(...);

Why is this a good idea? Because it will enable yielding inside PreUpdate() which will allow breaking down of writing huge entries in small quantities to disk/network, eliminating the need to allocate huge chunks of memory just for serialization.

Also, it'll probably unlock future developments as well, as yielding can be useful in other contexts.

romange · 2024-04-02T03:36:48Z

src/server/db_slice.h

+ private:
+  void Set(std::string s, std::string_view sv);
+
+  std::string s_;


nice. why not variant, btw?

TODO: Move this, use it in all places we have variant<string, string_view>

Why do we need a big custom class if a simple wrapper is enough? 🤷🏻‍♂️ we have something similar here:

dragonfly/src/server/table.h

Lines 102 to 118 in a93ad4e

struct Key {

operator std::string_view() const {

return visit([](const auto& s) -> std::string_view { return s; }, val_);

}

bool operator==(const Key& o) const {

return *this == std::string_view(o);

}

friend std::ostream& operator<<(std::ostream& o, const Key& key) {

return o << std::string_view(key);

}

// If the key is backed by a string_view, replace it with a string with the same value

void MakeOwned() const;

mutable std::variant<std::string_view, std::string> val_;

lol, this is WIP, I didn't mean for anyone to review it yet :)

Re/ variant: I wanted to see an implementation with both members, where s_ is only used as a storage medium, and sv_ is always used for inspecting the string. But I agree that variant is better (except for an added if in the visit path, but that's super unimportant and premature optimization).

Re/ big custom class - I'm not sure what you mean by big, but the Key you linked to is also a "custom class" 🤣 It's just a private class that's not usable outside of table, and is one of this things that should be replaced by a general utility.

Anyway, I moved the StringOrView class to a standalone file, took the variant approach like Key and moved table.h to use it.

But, as I said, this is still WIP, so unless you are really bored, I wouldn't look at this PR yet 🤓

src/server/db_slice.h

dranikpg · 2024-04-02T06:41:08Z

src/server/db_slice.h

+ private:
+  void Set(std::string s, std::string_view sv);
+
+  std::string s_;


TODO: Move this, use it in all places we have variant<string, string_view>

Why do we need a big custom class if a simple wrapper is enough? 🤷🏻‍♂️ we have something similar here:

dragonfly/src/server/table.h

Lines 102 to 118 in a93ad4e

struct Key {

operator std::string_view() const {

return visit([](const auto& s) -> std::string_view { return s; }, val_);

}

bool operator==(const Key& o) const {

return *this == std::string_view(o);

}

friend std::ostream& operator<<(std::ostream& o, const Key& key) {

return o << std::string_view(key);

}

// If the key is backed by a string_view, replace it with a string with the same value

void MakeOwned() const;

mutable std::variant<std::string_view, std::string> val_;

src/server/db_slice.h

dranikpg

I can't guarantee that every replacement was correct 😅 But the ones I looked at were ok

src/core/string_or_view.h

dranikpg · 2024-04-02T20:26:13Z

src/server/db_slice.h

+  // Auto-laundering iterator wrapper.
+  template <typename T> class IteratorT {


I'd suggest adding a very short comment what laundering means so it's show in code-completion snippets

dranikpg · 2024-04-02T20:34:07Z

src/server/table.cc

-  auto [it, inserted] = locks_.try_emplace(Key{key});
-  if (!inserted)            // If more than one transaction refers to a key
-    it->first.MakeOwned();  // we must fall back to using a self-contained string
+  auto [it, inserted] = locks_.try_emplace(Key::FromView(key));
+  if (!inserted)                              // If more than one transaction refers to a key
+    const_cast<Key&>(it->first).MakeOwned();  // we must fall back to using a self-contained string


Hmmm... seems legit 🤷🏻‍♂️ I don't think the hash table stores the keys as const in any place because it has at least to move out of them to move them around

fwiw it's exactly the same as before, except that now MakeOwned() is non-const (because it's not a const operation), and we do the const_cast because know that it wouldn't matter

dranikpg · 2024-04-02T20:54:22Z

src/server/db_slice.h

+
+  using Iterator = IteratorT<PrimeIterator>;
+  using ConstIterator = IteratorT<PrimeConstIterator>;
+  using ExpIterator = IteratorT<ExpireIterator>;
+  using ExpConstIterator = IteratorT<ExpireConstIterator>;
+


just typename T seems to be too general for structures that actually differ only verly slightly, it's always typename DashTable<K, V, P>::template Iterator<C, S>. It's possible to infer them, but that's very template-heavy code so not sure it's worth

adiholden · 2024-04-03T05:46:24Z

src/server/snapshot.cc

@@ -242,7 +242,8 @@ bool SliceSnapshot::BucketSaveCb(PrimeIterator it) {
    ++stats_.skipped;
    return false;
  }
-  db_slice_->FlushChangeToEarlierCallbacks(current_db_, it, snapshot_version_);
+  db_slice_->FlushChangeToEarlierCallbacks(current_db_, DbSlice::Iterator::FromPrime(it),


why do we need to call DbSlice::Iterator::FromPrime here?

FlushChangeToEarlierCallbacks calls pre-update callbacks. I think (but I'm not sure) that we will need to give them the auto-laundering iterator as well, as they might also yield.
wdyt?

is not the whole motivation of this PR is to allow SliceSnapshot::OnDbChange to yield?

We definitely want OnDbChange to be able to yield. And I think it's a good idea that it will have an auto laundering iterator to make things easier there. But it's not a necessity as the callbacks could launder automatically and anyway they should be using the values and not find etc.
but again, I think it's a good idea.

src/server/db_slice.cc

romange · 2024-04-03T06:28:54Z

src/core/string_or_view.cc

+  return sov;
+}
+
+bool StringOrView::operator==(const StringOrView& o) const {


nit: i would move onelines to the class definition and others to the header file and get rid of cc.

romange · 2024-04-03T06:32:24Z

src/server/generic_family.cc

@@ -288,8 +288,8 @@ void Renamer::Find(Transaction* t) {
    auto& db_slice = EngineShard::tlocal()->db_slice();
    auto [it, exp_it] = db_slice.FindReadOnly(t->GetDbContext(), res->key);

-    res->found = IsValid(it);


nit: you could provide IsValid override in db_slice.h and greatly reduce the size of the PR.

btw, this is why it existed in the first place - I had different type of iterators in the past and wanted to handle them "cleanly".

oh, i forgot about this comment. Please do not review yet, I'll fix this as well.

romange · 2024-04-03T06:36:47Z

src/server/db_slice.h

+    }
+
+   private:
+    void LaunderIfNeeded() const {  // const is a lie


nit: to pull the definition below DbSlice declaration.

romange · 2024-04-03T06:40:37Z

src/server/db_slice.h

+
+      uint64_t current_epoch = util::fb2::FiberSwitchEpoch();
+      if (current_epoch != fiber_epoch_) {
+        if (it_->first != key_.view()) {


add a note we currently do not shrink dashtables, but we do, we must also check if "it.egment_id: falls into a valid range.

chakaz · 2024-04-08T05:57:19Z

@romange / @adiholden friendly ping :)

adiholden · 2024-04-08T06:57:07Z

src/server/db_slice.h

@@ -330,12 +391,13 @@ class DbSlice {
  }

  // Check whether 'it' has not expired. Returns it if it's still valid. Otherwise, erases it
-  // from both tables and return PrimeIterator{}.
+  // from both tables and return Iterator{}.
  struct ItAndExp {
    PrimeIterator it;


Shouldnt we change this as well PrimeIterator -> Iterator and ExpireIterator -> ExpIterator ?

The thing is, we call this also in places where we have just PrimeIterator in our hands, like when we search directly in the table (not through DbSlice). I thought it would be better to leave as is, as it won't have any benefit to change.
wdyt?

Well its confusing and can lead to bugs but I think we can revisit this later

Can you give an example for a bug it could lead to?
Because it's strongly typed, I'm not sure what you think of. I am happy to change it now instead of later though.

If we have places in which we call ExpireIfNeeded when we call with Iterator and not PrimeIterator and than we will do another Find call. I believe we dont have such cases right now but the fact that we do such api that we enable calling ExpireIfNeeded with Iterator can lead to such bugs.

Right, that makes sense. Done.

adiholden · 2024-04-08T07:05:45Z

src/server/generic_family.cc

@@ -1500,7 +1500,7 @@ OpStatus GenericFamily::OpMove(const OpArgs& op_args, string_view key, DbIndex t
  db_slice.ActivateDb(target_db);

  bool sticky = from_res.it->first.IsSticky();
-  uint64_t exp_ts = db_slice.ExpireTime(from_res.exp_it);
+  uint64_t exp_ts = db_slice.ExpireTime(from_res.exp_it.GetInnerIt());


I think that you can call db_slice.ExpireTime(from_res.exp_it); right?

adiholden · 2024-04-08T07:34:55Z

src/server/string_family.cc

@@ -531,7 +529,7 @@ SinkReplyBuilder::MGetResponse OpMGet(bool fetch_mcflag, bool fetch_mcver, const
      }

      if (fetch_mcver) {
-        resp.mc_ver = it.GetVersion();
+        resp.mc_ver = it.GetInnerIt().GetVersion();


nit: it->GetVersion()

adiholden · 2024-04-08T07:45:46Z

src/server/db_slice.h

+  // falls into a valid range.
+  uint64_t current_epoch = util::fb2::FiberSwitchEpoch();
+  if (current_epoch != fiber_epoch_) {
+    if (it_->first != key_.view()) {


!it->IsOccupied() || it_->first != key_.view()

adiholden · 2024-04-08T11:09:01Z

src/server/db_slice.h

@@ -605,7 +609,7 @@ template <typename T> void DbSlice::IteratorT<T>::LaunderIfNeeded() const {
  // falls into a valid range.
  uint64_t current_epoch = util::fb2::FiberSwitchEpoch();
  if (current_epoch != fiber_epoch_) {
-    if (it_->first != key_.view()) {
+    if (!it_.IsOccupied() || it_->first != key_.view()) {


now you can remove the above comment as IsOccupied will check if we still fall into valid range

…nfly ( v1.16.1 → v1.17.0 ) (#3473) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.dragonflydb.io/dragonflydb/dragonfly](https://togithub.com/dragonflydb/dragonfly) | minor | `v1.16.1` -> `v1.17.0` | --- ### Release Notes <details> <summary>dragonflydb/dragonfly (docker.dragonflydb.io/dragonflydb/dragonfly)</summary> ### [`v1.17.0`](https://togithub.com/dragonflydb/dragonfly/releases/tag/v1.17.0) [Compare Source](https://togithub.com/dragonflydb/dragonfly/compare/v1.16.1...v1.17.0) ##### Dragonfly v1.17.0 Some prominent changes include: - Improved performance for MGET operations ([#2453](https://togithub.com/dragonflydb/dragonfly/issues/2453)) - Fix argument parsing in json.objkeys ([#2872](https://togithub.com/dragonflydb/dragonfly/issues/2872)) - Fix ipv6 support for replication ([#2889](https://togithub.com/dragonflydb/dragonfly/issues/2889)) - Support serialisation of bloom filters - saving to and loading from snapshots ([#2846](https://togithub.com/dragonflydb/dragonfly/issues/2846)) - Support of HLL PFADD ([#2761](https://togithub.com/dragonflydb/dragonfly/issues/2761)) - Support bullmq workloads that do not have `{}` hashtags in their queue names ([#2890](https://togithub.com/dragonflydb/dragonfly/issues/2890)) ##### What's Changed - fix: [#2745](https://togithub.com/dragonflydb/dragonfly/issues/2745) don't start migration process again after apply the same the same config is applied by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#2822 - feat(transaction): Idempotent callbacks (immediate runs) by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2453 - refactor(cluster): replace sync_id with node_id for slot migration [#2835](https://togithub.com/dragonflydb/dragonfly/issues/2835) by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#2838 - feat(tiering): Simple OpManager by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2781 - chore: implement path mutation for JsonFlat by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2805 - feat(cluster): add migration removing by config [#2835](https://togithub.com/dragonflydb/dragonfly/issues/2835) by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#2844 - chore: expose direct API on Bloom objects by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2845 - chore: generalize CompactObject::AllocateMR by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2847 - feat(tiering): Simplest small bins by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2810 - refactor: clean cluster slot migration code by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#2848 - fix(tests): Fix numsub test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2852 - fix: healthcheck for docker containers by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2853 - fix: possible crash in tls code by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2854 - fix(server): Do not block admin-port commands by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#2842 - fix(pytest): make pytests fail if server crash on shutdown by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#2827 - feat(server): add prints on takeover timeout by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#2856 - fix(pytest): dont check process return code on kill by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#2862 - fix: authorize the http connection to call commands by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2863 - feat(cluster): Send number of keys for incoming and outgoing migrations. by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#2858 - feat(tiering): TieredStorageV2 by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2849 - bug(server): set connection flags block/pause flag on all blocking commands by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#2816 - chore: serialize SBF by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2846 - fix: test_replicaof_reject_on_load crash on stop by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2818 - feat(dbslice): Add self-laundering iterator in `DbSlice` by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#2815 - chore: License update by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2767 - fix(acl): incompatibilities with acl load by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2867 - fix(json): make path optional in json.objkeys by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2872 - fix: return wrong type errors for SET...GET command by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2874 - fix(redis replication): remove partial sync flow ,not supported yet by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#2865 - chore: limit traffic logger only to the main interface by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2877 - chore: relax repltakeover constraints to only exclude write commands by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2873 - chore(replayer): Roll back to go1.18 by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2881 - fix: brpoplpush single shard to wake up blocked transactions by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2875 - chore: LockTable tracks fingerprints of keys by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2839 - chore: reject TLS handshake when our listener is plain TCP by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2882 - Add support for Sparse HLL PFADD by [@azuredream](https://togithub.com/azuredream) in [dragonflydb/dragonfly#2761 - feat server: bring visibility to script errors by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#2879 - chore: clean up REPLTAKEOVER flow by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2887 - chore(tiering): Move files and move kb literal to common by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2868 - chore(interpreter): Support object replies by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2885 - fix(ci/helm): Stick to v0.73.0 version of prom operator by [@Pothulapati](https://togithub.com/Pothulapati) in [dragonflydb/dragonfly#2893 - fix(acl): authentication with UDS socket by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2895 - feat(cluster): add repeated ACK if an error is happened by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#2892 - chore(blocking): Remove faulty DCHECK by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2898 - chore: add a clear link on how to build dragonfly from source by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2884 - feat(server): Allow configuration of hashtag extraction by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#2890 - fix: fix build under macos by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#2901 - fix(cluster_replication): replicate redis cluster node bug fix by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#2876 - fix(acl): skip http and add check on connection traversals by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2883 - fix(zset): Better memory consumption calculation by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#2900 - fix: fix ld for num converting by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#2902 - chore: add help string for memory_fiberstack_vms_bytes by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2903 - fix(sanitizers): false positive fail on multi_test::Eval by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#2896 - chore: pull helio and add ipv6 replication test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#2889 - chore: add ipv6 support for native linux release by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#2908 ##### Huge thanks to all the contributors! ❤️ **Full Changelog**: dragonflydb/dragonfly@v1.16.0...v1.17.0 </details>  Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>

chakaz added 5 commits March 26, 2024 08:11

WIP

8d49251

wip

0a3dce1

wip

19ec9d6

Merge branch 'main' into huge-it-wrapper

734877c

WIP

20089b8

romange reviewed Apr 2, 2024

View reviewed changes

src/server/db_slice.h Outdated Show resolved Hide resolved

dranikpg reviewed Apr 2, 2024

View reviewed changes

chakaz added 6 commits April 2, 2024 11:56

variant, separate file, use in table.h

5ee9dcd

Merge branch 'main' into huge-it-wrapper

e561275

GetInnerIt()

13c0282

comments

b11916f

eq order

bc07d05

exp it

e5f3839

chakaz changed the title ~~WIP: Self laundering DbSlice iterator~~ feat(dbslice): Add self-laundering iterator in DbSlice Apr 2, 2024

chakaz requested review from romange, dranikpg and adiholden April 2, 2024 18:37

dranikpg previously approved these changes Apr 2, 2024

View reviewed changes

adiholden reviewed Apr 3, 2024

View reviewed changes

src/server/db_slice.cc Show resolved Hide resolved

romange reviewed Apr 3, 2024

View reviewed changes

fixes

56e4dd6

chakaz dismissed dranikpg’s stale review via 56e4dd6 April 3, 2024 12:43

chakaz requested review from adiholden and romange April 3, 2024 12:46

IsValid

9637eb7

Merge branch 'main' into huge-it-wrapper

0e4c53d

adiholden reviewed Apr 8, 2024

View reviewed changes

chakaz added 3 commits April 8, 2024 11:23

gh comments

d67d6f1

gh comments

59bd37c

oops :)

8218fc9

chakaz force-pushed the huge-it-wrapper branch from 1b376e0 to 8218fc9 Compare April 8, 2024 10:37

adiholden reviewed Apr 8, 2024

View reviewed changes

chakaz added 2 commits April 8, 2024 14:27

remove comment

539a597

fix

b05d3ef

chakaz requested a review from adiholden April 8, 2024 18:17

adiholden previously approved these changes Apr 9, 2024

View reviewed changes

last(?) fixes

ca0b552

chakaz dismissed adiholden’s stale review via ca0b552 April 9, 2024 06:51

adiholden approved these changes Apr 9, 2024

View reviewed changes

chakaz merged commit 54c9633 into main Apr 9, 2024
10 checks passed

chakaz deleted the huge-it-wrapper branch April 9, 2024 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dbslice): Add self-laundering iterator in `DbSlice` #2815

feat(dbslice): Add self-laundering iterator in `DbSlice` #2815

chakaz commented Apr 1, 2024 •

edited

romange Apr 2, 2024

dranikpg Apr 2, 2024

chakaz Apr 2, 2024

dranikpg Apr 2, 2024

dranikpg left a comment

dranikpg Apr 2, 2024

dranikpg Apr 2, 2024

chakaz Apr 3, 2024

dranikpg Apr 2, 2024

adiholden Apr 3, 2024

chakaz Apr 3, 2024

romange Apr 4, 2024

chakaz Apr 4, 2024

romange Apr 3, 2024 •

edited

romange Apr 3, 2024

romange Apr 3, 2024

chakaz Apr 3, 2024

chakaz Apr 4, 2024

romange Apr 3, 2024

romange Apr 3, 2024 •

edited

chakaz commented Apr 8, 2024

adiholden Apr 8, 2024

chakaz Apr 8, 2024

adiholden Apr 8, 2024

chakaz Apr 8, 2024

adiholden Apr 8, 2024

chakaz Apr 8, 2024

adiholden Apr 8, 2024

adiholden Apr 8, 2024

adiholden Apr 8, 2024

adiholden Apr 8, 2024

	struct Key {
	operator std::string_view() const {
	return visit([](const auto& s) -> std::string_view { return s; }, val_);
	}

	bool operator==(const Key& o) const {
	return *this == std::string_view(o);
	}

	friend std::ostream& operator<<(std::ostream& o, const Key& key) {
	return o << std::string_view(key);
	}

	// If the key is backed by a string_view, replace it with a string with the same value
	void MakeOwned() const;

	mutable std::variant<std::string_view, std::string> val_;

		// Auto-laundering iterator wrapper.
		template <typename T> class IteratorT {

feat(dbslice): Add self-laundering iterator in DbSlice #2815

feat(dbslice): Add self-laundering iterator in DbSlice #2815

Conversation

chakaz commented Apr 1, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dranikpg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

romange Apr 3, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

romange Apr 3, 2024 • edited

Choose a reason for hiding this comment

chakaz commented Apr 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat(dbslice): Add self-laundering iterator in `DbSlice` #2815

feat(dbslice): Add self-laundering iterator in `DbSlice` #2815

chakaz commented Apr 1, 2024 •

edited

romange Apr 3, 2024 •

edited

romange Apr 3, 2024 •

edited