Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Increase common abstraction usage #511

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

dranikpg
Copy link
Contributor

Un-invent re-invented wheels 😄

Now that I introduced some more abstractions in my last PRs, we can use them in other places as well

@romange
Copy link
Collaborator

romange commented Nov 22, 2022

I have been using absl::Status for a long time https://github.com/abseil/abseil-cpp/blob/master/absl/status/status.h
but with helio and dragonfly I decided to go with the standard. But it seems passing a custom message is a valid use-case and we can not get away from it.

romange
romange previously approved these changes Nov 22, 2022
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
@romange romange merged commit 39a231d into dragonflydb:main Nov 22, 2022
@dranikpg dranikpg deleted the code-fixes branch November 29, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants