Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

fix typo: fix comment for func ParseNodesString #1163

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

fenggw-fnst
Copy link
Contributor

Signed-off-by: Guangwen Feng fenggw-fnst@cn.fujitsu.com

Ⅰ. Describe what this PR did

Fix comment for func ParseNodesString, 'ParseNodesString' -> 'ParseNodesSlice'

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
@codecov-io
Copy link

Codecov Report

Merging #1163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   47.18%   47.18%           
=======================================
  Files         113      113           
  Lines        7181     7181           
=======================================
  Hits         3388     3388           
  Misses       3527     3527           
  Partials      266      266
Impacted Files Coverage Δ
dfget/config/supernode_value.go 66.98% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7894da1...a432eda. Read the comment docs.

@lowzj
Copy link
Member

lowzj commented Jan 9, 2020

LGTM

@lowzj lowzj merged commit b32d1ca into dragonflyoss:master Jan 9, 2020
@fenggw-fnst fenggw-fnst deleted the work branch January 9, 2020 10:10
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
* remove CDN gc Debug log

Signed-off-by: sunwp <244372610@qq.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants