Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

test: add unit test case for func GetAsString #1172

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Conversation

hs0210
Copy link
Contributor

@hs0210 hs0210 commented Jan 10, 2020

Signed-off-by: Hu Shuai hus.fnst@cn.fujitsu.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
@codecov-io
Copy link

Codecov Report

Merging #1172 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
+ Coverage    47.3%   47.37%   +0.06%     
==========================================
  Files         113      113              
  Lines        7181     7181              
==========================================
+ Hits         3397     3402       +5     
+ Misses       3513     3508       -5     
  Partials      271      271
Impacted Files Coverage Δ
supernode/daemon/mgr/scheduler/manager.go 22.6% <0%> (+0.68%) ⬆️
pkg/syncmap/syncmap.go 36.08% <0%> (+4.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9769c2c...34cf285. Read the comment docs.

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit 9b9ca93 into dragonflyoss:master Jan 10, 2020
@hs0210 hs0210 deleted the work branch January 13, 2020 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants