This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
feature: implement minrate option for dfget when downloading a file #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
==========================================
+ Coverage 48.2% 48.25% +0.04%
==========================================
Files 99 99
Lines 5889 5896 +7
==========================================
+ Hits 2839 2845 +6
- Misses 2825 2827 +2
+ Partials 225 224 -1
Continue to review full report at Codecov.
|
lowzj
reviewed
Jul 9, 2019
cmd/dfget/app/root.go
Outdated
| flagSet.StringVarP(&localLimit, "locallimit", "s", "", | ||
| "network bandwidth rate limit for single download task, in format of 20M/m/K/k") | ||
| flagSet.StringVarP(&minRate, "minrate", "x", "", |
There was a problem hiding this comment.
It's unnecessary to set short flag for minRate.
Signed-off-by: yizheng <yizheng@cs.unc.edu>
Signed-off-by: yizheng <yizheng@cs.unc.edu>
yunfeiyanggzq
pushed a commit
to yunfeiyanggzq/Dragonfly
that referenced
this pull request
Jul 19, 2019
…ragonflyoss#664) * feature: implement minrate option for dfget when downloading a file Signed-off-by: yizheng <yizheng@cs.unc.edu> * remove short flag for minRate Signed-off-by: yizheng <yizheng@cs.unc.edu>
starnop
pushed a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
…ragonflyoss#664) * feature: implement minrate option for dfget when downloading a file Signed-off-by: yizheng <yizheng@cs.unc.edu> * remove short flag for minRate Signed-off-by: yizheng <yizheng@cs.unc.edu>
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
…ragonflyoss#664) * feature: implement minrate option for dfget when downloading a file Signed-off-by: yizheng <yizheng@cs.unc.edu> * remove short flag for minRate Signed-off-by: yizheng <yizheng@cs.unc.edu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yizheng yizheng@cs.unc.edu
Ⅰ. Describe what this PR did
Implement minrate option for dfget when downloading a file. Use "-x" to specify minrate.
Re-implement func calculateTimeout() to use minrate.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews