refactor: idgen pkg (#1715)

Signed-off-by: Gaius <gaius.qi@gmail.com>

client/dfget/dfget_test.go

@@ -25,24 +25,23 @@ import (
 	"testing"
 
 	"github.com/golang/mock/gomock"
+	"github.com/google/uuid"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"d7y.io/dragonfly/v2/client/config"
 	"d7y.io/dragonfly/v2/pkg/digest"
-	"d7y.io/dragonfly/v2/pkg/idgen"
 	"d7y.io/dragonfly/v2/pkg/source"
 	"d7y.io/dragonfly/v2/pkg/source/mocks"
 )
 
 func Test_downloadFromSource(t *testing.T) {
 	homeDir, err := os.UserHomeDir()
 	assert.Nil(t, err)
-	output := filepath.Join(homeDir, idgen.UUIDString())
+	output := filepath.Join(homeDir, uuid.New().String())
 	defer os.Remove(output)
 
-	content := idgen.UUIDString()
-
+	content := uuid.New().String()
 	sourceClient := mocks.NewMockResourceClient(gomock.NewController(t))
 	require.Nil(t, source.Register("http", sourceClient, func(request *source.Request) *source.Request {
 		return request

pkg/idgen/host_id.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 )
 
+// HostID generates a host id.
 func HostID(hostname string, port int32) string {
 	return fmt.Sprintf("%s-%d", hostname, port)
 }

pkg/idgen/peer_id.go

@@ -23,16 +23,12 @@ import (
 	"github.com/google/uuid"
 )
 
-var pid int
-
-func init() {
-	pid = os.Getpid()
-}
-
+// PeerID generates a peer id.
 func PeerID(ip string) string {
-	return fmt.Sprintf("%s-%d-%s", ip, pid, uuid.New())
+	return fmt.Sprintf("%s-%d-%s", ip, os.Getpid(), uuid.New())
 }
 
+// SeedPeerID generates a seed peer id.
 func SeedPeerID(ip string) string {
 	return fmt.Sprintf("%s_%s", PeerID(ip), "Seed")
 }