Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dfdaemon upload and object storage service add middlewares #1404

Merged
merged 3 commits into from Jun 21, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 21, 2022

Description

  • Dfdaemon upload and object storage service add middlewares.

Related Issue

#1249

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request kind/feature labels Jun 21, 2022
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 21, 2022
@gaius-qi gaius-qi self-assigned this Jun 21, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 21, 2022 08:01
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #1404 (7f9f58e) into main (6f95427) will decrease coverage by 0.20%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
- Coverage   45.17%   44.96%   -0.21%     
==========================================
  Files         110      110              
  Lines       10005    10018      +13     
==========================================
- Hits         4520     4505      -15     
- Misses       5020     5048      +28     
  Partials      465      465              
Flag Coverage Δ
Object-compatibility-e2etests ?
unittests 44.96% <76.47%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/daemon.go 5.41% <0.00%> (ø)
client/daemon/upload/upload_manager.go 57.14% <86.66%> (+5.58%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 45.45% <0.00%> (-2.17%) ⬇️
client/daemon/peer/peertask_conductor.go 58.35% <0.00%> (+0.20%) ⬆️

@gaius-qi gaius-qi merged commit 01e57e3 into main Jun 21, 2022
@gaius-qi gaius-qi deleted the feature/gin-middleware branch June 21, 2022 08:37
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: dfdaemon upload and object storage service add middlewares

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants