Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename digest func and add new digest func #1405

Merged
merged 1 commit into from Jun 21, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Rename digest func and add new digest func.

Related Issue

#1249

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 21, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 21, 2022 09:50
@gaius-qi gaius-qi self-assigned this Jun 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1405 (731e52a) into main (01e57e3) will increase coverage by 0.05%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
+ Coverage   45.03%   45.09%   +0.05%     
==========================================
  Files         110      110              
  Lines       10018    10022       +4     
==========================================
+ Hits         4512     4519       +7     
+ Misses       5045     5035      -10     
- Partials      461      468       +7     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.09% <41.17%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/digest/digest.go 54.90% <20.00%> (-4.68%) ⬇️
client/daemon/storage/local_storage.go 30.33% <50.00%> (ø)
client/daemon/storage/local_storage_subtask.go 27.72% <50.00%> (ø)
client/daemon/peer/peertask_conductor.go 57.14% <100.00%> (-1.41%) ⬇️
pkg/idgen/task_id.go 91.30% <100.00%> (ø)
...ent/daemon/peer/peertask_piecetask_synchronizer.go 46.75% <0.00%> (-0.87%) ⬇️
client/daemon/peer/peertask_piecetask_poller.go 47.10% <0.00%> (+16.66%) ⬆️

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit c56397f into main Jun 21, 2022
@gaius-qi gaius-qi deleted the feature/digest-rename branch June 21, 2022 10:01
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants