Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite interface{} to any #1419

Merged
merged 1 commit into from
Jun 30, 2022
Merged

feat: rewrite interface{} to any #1419

merged 1 commit into from
Jun 30, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Rewrite interface{} to any.

Related Issue

golang/go#49884

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 30, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 30, 2022 03:06
@gaius-qi gaius-qi self-assigned this Jun 30, 2022
Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #1419 (4043a31) into main (6955e7c) will increase coverage by 0.40%.
The diff coverage is 63.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
+ Coverage   44.30%   44.70%   +0.40%     
==========================================
  Files         113      113              
  Lines       10202    10202              
==========================================
+ Hits         4520     4561      +41     
+ Misses       5231     5187      -44     
- Partials      451      454       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 44.70% <63.41%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clientutil/types.go 0.00% <0.00%> (ø)
client/config/dynconfig.go 67.74% <ø> (ø)
client/daemon/proxy/proxy_manager.go 0.00% <0.00%> (ø)
client/daemon/storage/storage_manager.go 16.69% <0.00%> (ø)
internal/dynconfig/dynconfig.go 61.40% <ø> (ø)
internal/dynconfig/dynconfig_local.go 71.42% <ø> (ø)
internal/dynconfig/dynconfig_manager.go 72.41% <ø> (ø)
internal/job/job.go 16.41% <ø> (ø)
internal/job/logger.go 0.00% <ø> (ø)
pkg/cache/cache.go 75.00% <ø> (ø)
... and 21 more

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 726b19f into main Jun 30, 2022
@gaius-qi gaius-qi deleted the feature/interface-any branch June 30, 2022 03:31
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants