Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add daemon-socket-path #1521

Merged
merged 1 commit into from Aug 3, 2022
Merged

feat: add daemon-socket-path #1521

merged 1 commit into from Aug 3, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 3, 2022

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Add daemon socket path.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.6 milestone Aug 3, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner August 3, 2022 10:23
@gaius-qi gaius-qi self-assigned this Aug 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #1521 (db8a011) into main (9b0fd1a) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1521      +/-   ##
==========================================
+ Coverage   43.57%   43.59%   +0.01%     
==========================================
  Files         116      116              
  Lines       10720    10722       +2     
==========================================
+ Hits         4671     4674       +3     
+ Misses       5565     5563       -2     
- Partials      484      485       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 43.59% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/dfget.go 29.76% <ø> (ø)
client/daemon/daemon.go 5.14% <0.00%> (+0.02%) ⬆️
pkg/dfpath/dfpath.go 68.08% <75.00%> (+0.64%) ⬆️

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 5ee919e into main Aug 3, 2022
@gaius-qi gaius-qi deleted the feature/daemon-socket-path branch August 3, 2022 11:48
gaius-qi added a commit that referenced this pull request Aug 3, 2022
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants