-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add traffic shaper for download tasks #1654
Merged
gaius-qi
merged 6 commits into
dragonflyoss:main
from
greenhandatsjtu:feat/traffic-shaper
Sep 28, 2022
Merged
feat: add traffic shaper for download tasks #1654
gaius-qi
merged 6 commits into
dragonflyoss:main
from
greenhandatsjtu:feat/traffic-shaper
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: greenhandatsjtu <sunhengke@sjtu.edu.cn>
Codecov Report
@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
+ Coverage 42.03% 42.22% +0.19%
==========================================
Files 125 126 +1
Lines 15436 15594 +158
==========================================
+ Hits 6488 6585 +97
- Misses 8432 8491 +59
- Partials 516 518 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: greenhandatsjtu <sunhengke@sjtu.edu.cn>
jim3ma
requested changes
Sep 15, 2022
Signed-off-by: greenhandatsjtu <sunhengke@sjtu.edu.cn>
…onfly2 into feat/traffic-shaper
Signed-off-by: greenhandatsjtu <sunhengke@sjtu.edu.cn>
jim3ma
approved these changes
Sep 28, 2022
gaius-qi
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
Signed-off-by: greenhandatsjtu <sunhengke@sjtu.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: greenhandatsjtu sunhengke@sjtu.edu.cn
Description
For now, when a peer download from seed peers, the speed is limited by
perPeerRateLimit
andtotalRateLimit
.However, when there's only one task running with
perPeerRateLimit
set to 20M andtotalRateLimit
set to 100M, then 80% of the bandwidth is wasted. That's why we introduce traffic shaper.With the help of sampling traffic shaper, the rate limit of every task can be dynamically adjusted based on the context, the download speed of all tasks in the past second, which significantly improves the download performance.
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist