Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove task and host gc ttl #1735

Merged
merged 1 commit into from Oct 10, 2022
Merged

feat: remove task and host gc ttl #1735

merged 1 commit into from Oct 10, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Remove task and host gc ttl.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.7 milestone Oct 10, 2022
@gaius-qi gaius-qi self-assigned this Oct 10, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner October 10, 2022 04:52
Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #1735 (138b26e) into main (2c74adc) will increase coverage by 0.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
+ Coverage   43.69%   43.78%   +0.09%     
==========================================
  Files         128      128              
  Lines       15848    15863      +15     
==========================================
+ Hits         6924     6945      +21     
+ Misses       8402     8390      -12     
- Partials      522      528       +6     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 43.78% <50.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <0.00%> (ø)
scheduler/resource/host_manager.go 90.47% <33.33%> (-9.53%) ⬇️
scheduler/resource/task_manager.go 82.97% <42.85%> (-8.33%) ⬇️
scheduler/resource/peer_manager.go 83.51% <52.38%> (-10.46%) ⬇️
scheduler/resource/task.go 87.31% <100.00%> (+0.12%) ⬆️
scheduler/scheduler/evaluator/evaluator_base.go 91.91% <100.00%> (+0.08%) ⬆️
scheduler/service/service.go 76.30% <100.00%> (-1.01%) ⬇️
... and 6 more

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 088f4e6 into main Oct 10, 2022
@gaius-qi gaius-qi deleted the feature/ttl branch October 10, 2022 06:12
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants