Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update source temporary error logic #1739

Merged
merged 1 commit into from Oct 10, 2022
Merged

feat: update source temporary error logic #1739

merged 1 commit into from Oct 10, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Oct 10, 2022

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma
feat: update source temporary error logic
77a3618 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner October 10, 2022 09:52
gaius-qi
gaius-qi approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bigerous
bigerous approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit e9aae40 into main Oct 10, 2022
@gaius-qi gaius-qi deleted the feat/update-source-temporary-error-logic branch October 10, 2022 12:19
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
feat: update source temporary error logic (#1739)
2d46f64 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@bigerous bigerous bigerous approved these changes

@ansinlee ansinlee Awaiting requested review from ansinlee ansinlee is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@244372610 244372610 Awaiting requested review from 244372610 244372610 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@1037husterljx 1037husterljx Awaiting requested review from 1037husterljx 1037husterljx is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jim3ma @gaius-qi @bigerous