Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite task url and url meta #1740

Merged
merged 1 commit into from Oct 10, 2022
Merged

feat: overwrite task url and url meta #1740

merged 1 commit into from Oct 10, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Overwrite task url and url meta.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.7 milestone Oct 10, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner October 10, 2022 11:54
@gaius-qi gaius-qi self-assigned this Oct 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #1740 (4f518d5) into main (3f9309c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
+ Coverage   43.59%   43.62%   +0.02%     
==========================================
  Files         128      128              
  Lines       15863    15879      +16     
==========================================
+ Hits         6916     6927      +11     
- Misses       8421     8426       +5     
  Partials      526      526              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 43.62% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/service/service.go 76.65% <100.00%> (+0.34%) ⬆️
scheduler/resource/seed_peer.go 18.36% <0.00%> (-0.39%) ⬇️
client/daemon/proxy/proxy_sni.go 0.00% <0.00%> (ø)
client/daemon/proxy/proxy.go 13.76% <0.00%> (+0.15%) ⬆️

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit acb903b into main Oct 10, 2022
@jim3ma jim3ma deleted the feature/task branch October 10, 2022 12:38
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants