Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: corrupt data check #1946

Merged
merged 1 commit into from Dec 22, 2022
Merged

feat: corrupt data check #1946

merged 1 commit into from Dec 22, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Dec 21, 2022

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner December 21, 2022 13:09
@codecov-commenter
Copy link

Codecov Report

Merging #1946 (e0f2348) into main (92b01f0) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
- Coverage   42.79%   42.74%   -0.05%     
==========================================
  Files         133      133              
  Lines       16702    16731      +29     
==========================================
+ Hits         7147     7152       +5     
- Misses       9008     9032      +24     
  Partials      547      547              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 42.74% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_conductor.go 52.69% <0.00%> (-0.72%) ⬇️
client/daemon/rpcserver/rpcserver.go 49.14% <0.00%> (-1.00%) ⬇️
client/daemon/peer/piece_manager.go 53.40% <0.00%> (+0.40%) ⬆️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 48.37% <0.00%> (+0.97%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit fdb11e2 into main Dec 22, 2022
@gaius-qi gaius-qi deleted the feat/corrupt-data-check branch December 22, 2022 02:57
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants