Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add manager v2 api #1990

Merged
merged 2 commits into from Jan 10, 2023
Merged

feat: add manager v2 api #1990

merged 2 commits into from Jan 10, 2023

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Add manager v2 api.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.9 milestone Jan 10, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner January 10, 2023 04:27
@gaius-qi gaius-qi self-assigned this Jan 10, 2023
@gaius-qi gaius-qi force-pushed the feature/manager-v2 branch 2 times, most recently from 6479dd9 to 5fe6294 Compare January 10, 2023 10:01
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #1990 (a5bc410) into main (da0cf8d) will decrease coverage by 2.20%.
The diff coverage is 1.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
- Coverage   42.90%   40.70%   -2.21%     
==========================================
  Files         134      136       +2     
  Lines       16799    17646     +847     
==========================================
- Hits         7207     7182      -25     
- Misses       9043     9915     +872     
  Partials      549      549              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 40.70% <1.35%> (-2.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_manager_mock.go 36.81% <0.00%> (ø)
client/daemon/peer/piece_manager_mock.go 0.00% <0.00%> (ø)
manager/rpcserver/manager_server_v1.go 0.00% <0.00%> (ø)
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)
manager/rpcserver/rpcserver.go 0.00% <0.00%> (-2.89%) ⬇️
scheduler/resource/seed_peer_mock.go 0.00% <0.00%> (ø)
scheduler/resource/seed_peer_client_mock.go 27.41% <33.33%> (ø)
client/config/dynconfig.go 74.19% <100.00%> (ø)
client/config/dynconfig_manager.go 59.87% <100.00%> (ø)
client/daemon/announcer/announcer.go 8.69% <100.00%> (ø)
... and 8 more

…e/manager-v2

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit 6c7e8bf into main Jan 10, 2023
@gaius-qi gaius-qi deleted the feature/manager-v2 branch January 10, 2023 14:23
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants