Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: announcer and dynconfig with v2 verison of the manager grpc #2037

Merged
merged 1 commit into from Feb 6, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 6, 2023

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Refactor announcer and dynconfig with v2 verison of the manager grpc.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.9 milestone Feb 6, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner February 6, 2023 08:07
@gaius-qi gaius-qi self-assigned this Feb 6, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner February 6, 2023 08:07
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #2037 (fb59af9) into main (fe7b7fd) will increase coverage by 0.00%.
The diff coverage is 74.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2037   +/-   ##
=======================================
  Coverage   40.83%   40.83%           
=======================================
  Files         144      144           
  Lines       18131    18132    +1     
=======================================
+ Hits         7403     7404    +1     
  Misses      10173    10173           
  Partials      555      555           
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 40.83% <74.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/dynconfig.go 22.22% <54.54%> (ø)
scheduler/announcer/announcer.go 51.28% <60.00%> (ø)
scheduler/resource/peer.go 68.69% <100.00%> (ø)
scheduler/resource/seed_peer_client.go 88.88% <100.00%> (ø)
scheduler/service/service_v1.go 64.70% <100.00%> (+0.03%) ⬆️

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit e45b874 into main Feb 6, 2023
@gaius-qi gaius-qi deleted the feature/dynconfig branch February 6, 2023 08:58
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
…dragonflyoss#2037)

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants