Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stat DownloadPeerCount and DownloadPieceCount #2180

Merged
merged 1 commit into from Mar 15, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • Fix DownloadPeerCount and DownloadPieceCount metrics.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Mar 15, 2023
@gaius-qi gaius-qi added this to the v2.0.9 milestone Mar 15, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner March 15, 2023 10:23
@gaius-qi gaius-qi self-assigned this Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #2180 (e76a54a) into main (1037b6d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2180      +/-   ##
==========================================
+ Coverage   48.22%   48.24%   +0.01%     
==========================================
  Files         141      141              
  Lines       19658    19668      +10     
==========================================
+ Hits         9481     9488       +7     
- Misses       9589     9592       +3     
  Partials      588      588              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 48.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/service/service_v2.go 83.80% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 5feacb4 into main Mar 15, 2023
@gaius-qi gaius-qi deleted the feature/metrics-scheduler branch March 15, 2023 10:36
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants