New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add network topology functions #2364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
…age into csv file function Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Codecov Report
@@ Coverage Diff @@
## main #2364 +/- ##
==========================================
+ Coverage 49.50% 49.58% +0.08%
==========================================
Files 148 148
Lines 19754 19866 +112
==========================================
+ Hits 9779 9851 +72
- Misses 9363 9386 +23
- Partials 612 629 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
fcgxz2003
changed the title
[WIP] feat: add network topology functions.
[WIP] feat: add network topology functions
May 22, 2023
MinH-09
reviewed
May 22, 2023
fcgxz2003
commented
May 23, 2023
Signed-off-by: XZ <834756128@qq.com>
fcgxz2003
changed the title
[WIP] feat: add network topology functions
feat: add network topology functions
May 23, 2023
gaius-qi
requested changes
May 23, 2023
gaius-qi
requested changes
May 23, 2023
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
gaius-qi
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
Signed-off-by: XZ <834756128@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct the network topology by storing probes in redis.
There are three types of storage structures in redis:
network-topology:src:dest (hash)
Store averageRTT, createdAt, updatedAt of multiple probes from src to dest.
probes:src:dest (list)
Store probes list from src to dest.
visit-times:src (string)
Store visit times of src in this network topology, in other word, the number of times src is probed.
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist