Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network topology functions #2364

Merged
merged 20 commits into from May 24, 2023
Merged

Conversation

fcgxz2003
Copy link
Member

@fcgxz2003 fcgxz2003 commented May 19, 2023

Construct the network topology by storing probes in redis.
There are three types of storage structures in redis:

network-topology:src:dest (hash)
Store averageRTT, createdAt, updatedAt of multiple probes from src to dest.
probes:src:dest (list)
Store probes list from src to dest.
visit-times:src (string)
Store visit times of src in this network topology, in other word, the number of times src is probed.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@fcgxz2003 fcgxz2003 requested a review from a team as a code owner May 19, 2023 08:04
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
…age into csv file function

Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #2364 (93e8636) into main (5f457ca) will increase coverage by 0.08%.
The diff coverage is 70.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2364      +/-   ##
==========================================
+ Coverage   49.50%   49.58%   +0.08%     
==========================================
  Files         148      148              
  Lines       19754    19866     +112     
==========================================
+ Hits         9779     9851      +72     
- Misses       9363     9386      +23     
- Partials      612      629      +17     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.58% <70.18%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/networktopology/probes.go 66.66% <63.33%> (-21.65%) ⬇️
scheduler/networktopology/network_topology.go 80.76% <78.87%> (+80.76%) ⬆️

... and 1 file with indirect coverage changes

Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003 fcgxz2003 changed the title [WIP] feat: add network topology functions. [WIP] feat: add network topology functions May 22, 2023
scheduler/networktopology/network_topology.go Outdated Show resolved Hide resolved
scheduler/networktopology/network_topology.go Outdated Show resolved Hide resolved
scheduler/networktopology/network_topology.go Outdated Show resolved Hide resolved
scheduler/networktopology/network_topology.go Outdated Show resolved Hide resolved
scheduler/networktopology/network_topology.go Outdated Show resolved Hide resolved
fcgxz2003 and others added 3 commits May 23, 2023 09:30
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003 fcgxz2003 changed the title [WIP] feat: add network topology functions feat: add network topology functions May 23, 2023
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 0b269ff into dragonflyoss:main May 24, 2023
21 checks passed
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: XZ <834756128@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants