Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add announceToTrainer in scheduler #2371

Merged
merged 1 commit into from May 22, 2023
Merged

Conversation

gaius-qi
Copy link
Member

Description

  • Add announceToTrainer in scheduler.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler labels May 22, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone May 22, 2023
@gaius-qi gaius-qi self-assigned this May 22, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner May 22, 2023 14:09
@gaius-qi gaius-qi force-pushed the feature/announce-trainer branch 4 times, most recently from 2c1eb6e to ffbde0d Compare May 22, 2023 14:51
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #2371 (8ef19e6) into main (0cddb97) will decrease coverage by 0.22%.
The diff coverage is 7.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
- Coverage   49.71%   49.49%   -0.22%     
==========================================
  Files         148      148              
  Lines       19645    19754     +109     
==========================================
+ Hits         9766     9777      +11     
- Misses       9265     9365     +100     
+ Partials      614      612       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.49% <7.43%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/announcer/announcer.go 13.88% <1.75%> (-37.40%) ⬇️
scheduler/config/config.go 88.37% <100.00%> (+0.18%) ⬆️

... and 2 files with indirect coverage changes

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit 5f457ca into main May 22, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/announce-trainer branch May 22, 2023 15:26
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants