Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move redis key to pkg/redis package #2378

Merged
merged 1 commit into from May 24, 2023
Merged

feat: move redis key to pkg/redis package #2378

merged 1 commit into from May 24, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • Network Topology adds functions to new redis key and move the manager's redis key to pkg/redis.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler manager labels May 24, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone May 24, 2023
@gaius-qi gaius-qi self-assigned this May 24, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner May 24, 2023 07:44
@gaius-qi
feat: move redis key to pkg/redis package
7a82290 
Network Topology adds functions to new redis key and move the manager's redis key to pkg/redis.

Signed-off-by: Gaius <gaius.qi@gmail.com>
fcgxz2003
fcgxz2003 reviewed May 24, 2023
View reviewed changes
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi requested a review from fcgxz2003 May 24, 2023 07:52
@gaius-qi gaius-qi merged commit 1764fd7 into main May 24, 2023
17 of 18 checks passed
@gaius-qi gaius-qi deleted the feature/redis-key branch May 24, 2023 07:54
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: move redis key to pkg/redis package (#2378)
8181766 
Network Topology adds functions to new redis key and move the manager's redis key to pkg/redis.

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyy0322 hyy0322 hyy0322 approved these changes

@cndoit18 cndoit18 cndoit18 approved these changes

@jim3ma jim3ma Awaiting requested review from jim3ma jim3ma is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yxxhero yxxhero Awaiting requested review from yxxhero yxxhero is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@fcgxz2003 fcgxz2003 Awaiting requested review from fcgxz2003

Assignees

@gaius-qi gaius-qi

Labels
enhancement New feature or request manager scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaius-qi @hyy0322 @fcgxz2003 @cndoit18