Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: network topology package in scheduler #2380

Merged
merged 1 commit into from May 24, 2023
Merged

refactor: network topology package in scheduler #2380

merged 1 commit into from May 24, 2023
+87 −112

Conversation

gaius-qi
Copy link
Member

Description

  • Refactor network topology package in scheduler.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler labels May 24, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone May 24, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner May 24, 2023 08:42
@gaius-qi gaius-qi self-assigned this May 24, 2023
fcgxz2003
fcgxz2003 previously approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero
Copy link
Member

yxxhero commented May 24, 2023

lint

@gaius-qi
refactor: network topology package in scheduler
301d306 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi
Copy link
Member Author

lint

Fix

@gaius-qi gaius-qi merged commit 04f2585 into main May 24, 2023
18 checks passed
@gaius-qi gaius-qi deleted the feature/network-topology branch May 24, 2023 08:53
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
refactor: network topology package in scheduler (#2380)
e1113c1 
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcgxz2003 fcgxz2003 fcgxz2003 left review comments

@liubin liubin Awaiting requested review from liubin liubin is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@KubeStacker KubeStacker Awaiting requested review from KubeStacker KubeStacker is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@hyy0322 hyy0322 Awaiting requested review from hyy0322 hyy0322 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
enhancement New feature or request scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaius-qi @yxxhero @fcgxz2003