Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Reverse function to slice #2381

Merged
merged 1 commit into from May 24, 2023
Merged

feat: add Reverse function to slice #2381

merged 1 commit into from May 24, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • Add Reverse function to slice.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added enhancement New feature or request scheduler labels May 24, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone May 24, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner May 24, 2023 08:46
@gaius-qi gaius-qi self-assigned this May 24, 2023
@yxxhero
Copy link
Member

yxxhero commented May 24, 2023

@gaius-qi add some unit test?

@fcgxz2003
Copy link
Member

@gaius-qi add some unit test?
I'll fill in the unit tests.

@gaius-qi gaius-qi merged commit dec9948 into main May 24, 2023
19 checks passed
@gaius-qi gaius-qi deleted the feature/reverse-slice branch May 24, 2023 08:53
gaius-qi added a commit that referenced this pull request May 24, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
@yxxhero
Copy link
Member

yxxhero commented May 24, 2023

@fcgxz2003 thanks so much.

gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants