Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call MakeNamespaceKeyInScheduler function error #2383

Merged
merged 1 commit into from May 25, 2023

Conversation

zhoulizhen
Copy link
Contributor

@zhoulizhen zhoulizhen commented May 24, 2023

It should call MakeNamespaceKeyInScheduler() function in MakeKeyInScheduler() function, instead of MakeNamespaceKeyInManager() function.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhoulizhen <2313464078@qq.com>
@zhoulizhen zhoulizhen requested a review from a team as a code owner May 24, 2023 14:27
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #2383 (9241245) into main (b9c9b95) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
- Coverage   49.36%   49.34%   -0.02%     
==========================================
  Files         146      146              
  Lines       19672    19672              
==========================================
- Hits         9711     9708       -3     
- Misses       9352     9355       +3     
  Partials      609      609              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.34% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 1a11fc2 into dragonflyoss:main May 25, 2023
21 checks passed
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: zhoulizhen <2313464078@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants